Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of pagination for Apigee X Teams #288

Merged
merged 7 commits into from
Aug 18, 2023
Merged

Implementation of pagination for Apigee X Teams #288

merged 7 commits into from
Aug 18, 2023

Conversation

shishir-intelli
Copy link
Collaborator

Closes #287

@shishir-intelli shishir-intelli added the bug Something isn't working label Aug 9, 2023
@shishir-intelli shishir-intelli added this to the 2.1.1 milestone Aug 9, 2023
@shishir-intelli shishir-intelli added this to In progress in Drupal-based Development Board via automation Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023 •
edited
Loading

Codecov Report

Merging #288 (032e65d) into 2.x (a2f13c3) will decrease coverage by 0.77%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x     #288      +/-   ##
============================================
- Coverage     84.63%   83.86%   -0.77%     
- Complexity     1718     1727       +9     
============================================
  Files           345      348       +3     
  Lines          4575     4617      +42     
============================================
  Hits           3872     3872              
- Misses          703      745      +42
Flag Coverage Δ
unittests 83.86% <0.00%> (-0.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/Api/ApigeeX/Controller/AppGroupController.php 0.00% <ø> (ø)
...i/ApigeeX/Controller/PaginatedEntityController.php 0.00% <0.00%> (ø)
...ntroller/PaginatedEntityListingControllerTrait.php 0.00% <0.00%> (ø)
...c/Api/ApigeeX/Controller/PaginationHelperTrait.php 0.00% <0.00%> (ø)

@shishir-intelli shishir-intelli marked this pull request as ready for review August 9, 2023 06:36
divya-intelli
divya-intelli approved these changes Aug 18, 2023
View reviewed changes
Copy link
Collaborator

@divya-intelli divya-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Drupal-based Development Board automation moved this from In progress to Reviewer approved Aug 18, 2023
@shishir-intelli shishir-intelli merged commit 97c952b into apigee:2.x Aug 18, 2023
5 of 6 checks passed
Drupal-based Development Board automation moved this from Reviewer approved to Done Aug 18, 2023
@shishir-intelli shishir-intelli deleted the pagination2x branch August 23, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divya-intelli divya-intelli divya-intelli approved these changes

@giteshk giteshk Awaiting requested review from giteshk

Assignees
No one assigned
Labels
bug Something isn't working
Projects
Drupal-based Development Board
  
Done
Milestone
2.1.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shishir-intelli @divya-intelli