Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended AppGroup class from base class AppOwner #294

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

shishir-intelli
Copy link
Collaborator

Closes #293

@shishir-intelli shishir-intelli added the enhancement New feature or request label Aug 18, 2023
@shishir-intelli shishir-intelli added this to the 2.1.1 milestone Aug 18, 2023
@shishir-intelli shishir-intelli added this to In progress in Drupal-based Development Board via automation Aug 18, 2023
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #294 (c16bfcc) into 2.x (97c952b) will not change coverage.
Report is 1 commits behind head on 2.x.
The diff coverage is n/a.

❗ Current head c16bfcc differs from pull request most recent head f514626. Consider uploading reports for the commit f514626 to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x     #294   +/-   ##
=========================================
  Coverage     83.86%   83.86%           
  Complexity     1727     1727           
=========================================
  Files           348      348           
  Lines          4617     4617           
=========================================
  Hits           3872     3872           
  Misses          745      745           
Flag Coverage Δ
unittests 83.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/Api/ApigeeX/Entity/AppGroup.php 0.00% <ø> (ø)

Drupal-based Development Board automation moved this from In progress to Reviewer approved Aug 22, 2023
Copy link
Collaborator

@divya-intelli divya-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shishir-intelli shishir-intelli merged commit 6d023f1 into apigee:2.x Aug 22, 2023
5 checks passed
Drupal-based Development Board automation moved this from Reviewer approved to Done Aug 22, 2023
@shishir-intelli shishir-intelli deleted the baseclass_appowner_2x branch August 23, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

2 participants