Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements for query parameters #311

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

kedarkhaire
Copy link
Collaborator

Added way to pass query parameters.
Required to complete the Apigee Edge request of filtering with ChannelId

@kedarkhaire kedarkhaire added the enhancement New feature or request label Sep 22, 2023
@kedarkhaire kedarkhaire added this to the 3.0.2 milestone Sep 22, 2023
@kedarkhaire kedarkhaire self-assigned this Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #311 (f0a4a2b) into 3.x (d9b6ec1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##                3.x     #311   +/-   ##
=========================================
  Coverage     87.60%   87.60%           
  Complexity     1749     1749           
=========================================
  Files           349      349           
  Lines          4705     4705           
=========================================
  Hits           4122     4122           
  Misses          583      583           
Flag Coverage Δ
unittests 87.60% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ntroller/PaginatedEntityListingControllerTrait.php 100.00% <100.00%> (ø)

@kedarkhaire kedarkhaire marked this pull request as ready for review October 5, 2023 13:42
Copy link
Collaborator

@shishir-intelli shishir-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kedarkhaire kedarkhaire merged commit fe7267d into apigee:3.x Oct 16, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants