Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of empty response #364

Merged
merged 3 commits into from
May 24, 2024
Merged

Fix handling of empty response #364

merged 3 commits into from
May 24, 2024

Conversation

mxr576
Copy link
Contributor

@mxr576 mxr576 commented May 13, 2024

Closes #363

@mxr576
Copy link
Contributor Author

mxr576 commented May 14, 2024

Test failures looks unrelated... what is happening?

@kedarkhaire
Copy link
Collaborator

kedarkhaire commented May 14, 2024

Hi @mxr576
The codecov-actions fails due to the invalid key, we will update the key soon also the PR will be updated soon #360.
The other 7 failures on tests might be due to the upgraded vendors, we are looking into it on this PR #362 with issue #361
Thanks!

Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 87.54%. Comparing base (3073f76) to head (8df40de).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x     #364      +/-   ##
============================================
- Coverage     87.56%   87.54%   -0.02%     
- Complexity     1753     1754       +1     
============================================
  Files           349      349              
  Lines          4599     4601       +2     
============================================
+ Hits           4027     4028       +1     
- Misses          572      573       +1     
Flag Coverage Δ
unittests 87.54% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...oller/NonPaginatedEntityListingControllerTrait.php 90.90% <50.00%> (-9.10%) ⬇️

@mxr576
Copy link
Contributor Author

mxr576 commented May 22, 2024

@kedarkhaire Hi, do you have an update on when the failing test suites in master will be fixed?

Copy link
Collaborator

@kedarkhaire kedarkhaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shishir-intelli shishir-intelli merged commit dd20c63 into apigee:3.x May 24, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants