Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restricted Symfony update to 6.4.6 due to issue in latest version 6.4.7 #365

Merged
merged 10 commits into from
May 24, 2024

Conversation

kedarkhaire
Copy link
Collaborator

Fixes #361

Copy link
Collaborator

@divya-intelli divya-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't restrict the version.

composer.json Outdated Show resolved Hide resolved
@mxr576
Copy link
Contributor

mxr576 commented May 22, 2024

If there is an issue with symfony/[package] 6.4.7, just add a conflict rule to package(s) and that version, nothing more.

@mxr576
Copy link
Contributor

mxr576 commented May 22, 2024

Also referencing the related issue - at least here -from Symfony's issue queue would be beneficial.

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.56%. Comparing base (9c5d2fd) to head (5d44a4c).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x     #365      +/-   ##
============================================
+ Coverage     87.50%   87.56%   +0.06%     
- Complexity     1722     1753      +31     
============================================
  Files           343      349       +6     
  Lines          4176     4599     +423     
============================================
+ Hits           3654     4027     +373     
- Misses          522      572      +50     
Flag Coverage Δ
unittests 87.56% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...zation/Denormalizer/ReportCriteriaDenormalizer.php 96.96% <100.00%> (ø)
src/Denormalizer/ObjectDenormalizer.php 96.87% <100.00%> (+1.04%) ⬆️

... and 113 files with indirect coverage changes

@mxr576
Copy link
Contributor

mxr576 commented May 23, 2024

Also referencing the related issue - at least here -from Symfony's issue queue would be beneficial.

Could this be related to this?

symfony/symfony#54983

@kedarkhaire
Copy link
Collaborator Author

Yes @mxr576 that can be the related to the mentioned issue as only symfony/serializer with version 6.4.7 is causing issue.

Copy link
Collaborator

@divya-intelli divya-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kedarkhaire kedarkhaire merged commit 3073f76 into apigee:3.x May 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update symfony minimum version to 6.4
3 participants