Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRUP-796] Replace apigee_edge_apidocs with apigee_api_catalog #114

Merged
merged 6 commits into from May 28, 2019

Conversation

shadcn
Copy link
Contributor

@shadcn shadcn commented May 21, 2019

This PR replaces the apigee_edge_apidcos with the new apigee_api_catalog module.

  1. I've updated the configuration and dependencies.
  2. Added the requirements in composer.json

Note: this pulls in the 8.x-1.0-alpha1 release for which does not have the path rename yet (apidoc to apis).

We can create a follow up PR to add this later.

@googlebot googlebot added the cla: yes Indicates CLA has been signed label May 21, 2019
@shadcn shadcn requested review from jacine and cnovak May 21, 2019 10:53
Copy link
Contributor

@jacine jacine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking this as needed changes until we get the Categories field back.

@shadcn
Copy link
Contributor Author

shadcn commented May 23, 2019

This is on hold pending apigee/apigee-api-catalog-drupal#7

Copy link
Contributor

@jacine jacine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this, and it's all good! Thanks @arshad! 👏

@shadcn shadcn added this to the 8.x-1.0-rc1 milestone May 24, 2019
@shadcn
Copy link
Contributor Author

shadcn commented May 28, 2019

apigee/apigee-api-catalog-drupal#7 was merged and @cnovak released https://github.com/apigee/apigee-api-catalog-drupal/releases/tag/8.x-1.0-beta1.

@jacine This is ready for another quick review and merge.

composer.json Outdated Show resolved Hide resolved
@cnovak cnovak changed the title [DRUP-796] Replace apigee_edge_apidcos with apigee_api_catalog [DRUP-796] Replace apigee_edge_apidocs with apigee_api_catalog May 28, 2019
@jacine jacine merged commit 33c8549 into apigee:8.x-1.x May 28, 2019
@jacine jacine deleted the DRUP-796-api-catalog branch May 28, 2019 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates CLA has been signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants