Table <td> alignment issue noticed on Payment methods page

[jacine]

Describe the bug
<td> alignment is inconsistent, I think partially because of .btn-link / operations. I just ran into this somewhere else that I cannot recall ATM, but we should fix this globally if we can.

To Reproduce
Steps to reproduce the behavior:

1. Log in and go to "Payment methods" page.
2. Add one or more payment methods.
3. Notice the the <td> elements are not aligned consistently.

Expected behavior
Should probably all align top vertically?

Screenshots

[shadcn]

Looks like commerce is replacing dropbuttons with normal links. See \Drupal\commerce_payment\PaymentMethodListBuilder::buildOperations.

We could go back to dropbutton? This looks cleaner but might still need some alignment fixes.

[jacine]

Hmm... 🤔 What do you think the odds of them changing this in the future are? Looks like this is a standard, rigid entity list, that can barely be manipulated at all, so it may be safe...

I guess another option is NOT to use .btn-link and use/create a button style that looks like this, e.g. btn-tertiary?

[shadcn]

I guess another option is NOT to use .btn-link and use/create a button style that looks like this, e.g. btn-tertiary?

Let's see if we see this again then we can add a new .btn-tertiary.

For now, I removed the padding with the buttons. Let me know what you think.

[jacine]

Fixed by #199.

[jacine]

I guess another option is NOT to use .btn-link and use/create a button style that looks like this, e.g. btn-tertiary?

Let's see if we see this again then we can add a new .btn-tertiary.

For now, I removed the padding with the buttons. Let me know what you think.

Yes, this works!