Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#186] Fix for asterisk with checkbox/description #201

Merged
merged 2 commits into from Jul 10, 2019
Merged

[#186] Fix for asterisk with checkbox/description #201

merged 2 commits into from Jul 10, 2019

Conversation

jacine
Copy link
Contributor

@jacine jacine commented Jul 10, 2019 •
edited

Fixes #186.

Contains commits already merged to 8.x-1.x. Those are open in #200.

Unchecked

Screen Shot 2019-07-10 at 10 23 36 AM

Checked

Screen Shot 2019-07-10 at 10 23 52 AM

@googlebot googlebot added the cla: yes Indicates CLA has been signed label Jul 10, 2019
@jacine jacine requested a review from shadcn July 10, 2019 14:31
@jacine jacine force-pushed the 186-checkbox-description-asterisk branch from d4431eb to 188c40a Compare July 10, 2019 17:17
shadcn
shadcn approved these changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@shadcn shadcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Checkboxes looking good with description and asterisk. Thanks @jacine

@shadcn shadcn merged commit f8e6e26 into apigee:8.x-1.x-monetization Jul 10, 2019
@shadcn shadcn mentioned this pull request Jul 10, 2019
Closed
@jacine jacine added this to the 8.x-1.3 milestone Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadcn shadcn shadcn approved these changes

Assignees
No one assigned
Labels
cla: yes Indicates CLA has been signed
Projects
None yet
Milestone
8.x-1.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jacine @shadcn @googlebot