Accessing entity storage in service constructors causes a container error.

[Jaesin]

Q	A
Bug?	yes
Module Version	8.x-1.x
PHP Client version	N/A
Requires PHP client fix	no

Actual Behavior

Rebuilding the container cache will fail if a service used in an entity hook accesses a the entity storage.

Expected Behavior

All services should be Inject-able.

Steps to Reproduce the behavior

Call a service during an entity hook that injects the apigee_edge_teams.team_permissions service.

Proposed Solution

Only the entity type manager in services and don't use then in the constructor.

[Jaesin]

A quick fix patch without tests.
140-1.diff.txt

[Jaesin]

Adds a demonstration test.

140-2-test-and-fix.diff.txt
140-2-test-only.diff.txt

[mxr576]

@Jaesin Thanks for the detailed description and especially for the tests files, please test my fix from the #141.

 $ ./test.sh web/modules/contrib/apigee_edge/modules/apigee_edge_teams/tests/src/Kernel/DependencyInjectionTest.php 
PHPUnit 6.5.14 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.1.17 with Xdebug 2.6.0
Configuration: /var/www/html/web/core/phpunit.xml.dist

Testing Drupal\Tests\apigee_edge_teams\Kernel\DependencyInjectionTest
Test 'Drupal\Tests\apigee_edge_teams\Kernel\DependencyInjectionTest::testDependencyInjection' started
Test 'Drupal\Tests\apigee_edge_teams\Kernel\DependencyInjectionTest::testDependencyInjection' ended


Time: 1.54 seconds, Memory: 6.00MB

OK (1 test, 1 assertion)

[mxr576]

140-2-better-test-only.diff.txt

POC for #141

[arunz6161]

Was been fixed by #144