Drupal 10 compatibility. #761

dpagini · 2022-11-17T17:23:30Z

Is your feature request related to a problem? Please describe.

Release a module version that is compatible with Drupal 10.

Describe the solution you would like

Need to have this module ship a D10/PHP8.1 compatible version before we can update our site to Drupal 10.

Describe alternatives you have considered

Not using the Apigee suite of modules?

Additional context

N/A

VladimirAus · 2023-01-07T09:38:08Z

Running ./vendor/bin/drush -l default -y upgrade_status:analyze apigee_edge

Result


================================================================================
Apigee Edge,  2.0.6
Scanned on Sat, 07/01/2023 - 19:36

FILE:
modules/contrib/apigee_edge/modules/apigee_edge_teams/src/Controller/TeamMembers
List.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 118  Relying on entity queries to check access by default is     
                    deprecated in drupal:9.2.0 and an error will be thrown from 
                    drupal:10.0.0. Call                                         
                    \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with
                    TRUE or FALSE to specify whether access should be checked.  
--------------------------------------------------------------------------------

FILE:
modules/contrib/apigee_edge/modules/apigee_edge_teams/src/Entity/Form/TeamForm.p
hp

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 156  Relying on entity queries to check access by default is     
                    deprecated in drupal:9.2.0 and an error will be thrown from 
                    drupal:10.0.0. Call                                         
                    \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with
                    TRUE or FALSE to specify whether access should be checked.  
--------------------------------------------------------------------------------

FILE:
modules/contrib/apigee_edge/modules/apigee_edge_teams/src/Entity/Storage/TeamApp
Storage.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 38   Class Drupal\apigee_edge_teams\Entity\Storage\TeamAppStorage
                    extends @internal class                                     
                    Drupal\apigee_edge\Entity\Storage\AppStorage.               
--------------------------------------------------------------------------------

FILE: modules/contrib/apigee_edge/apigee_edge.libraries.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    The 'apigee_edge.analytics' library is depending on a       
                    deprecated library. The core/jquery.once asset library is   
                    deprecated in Drupal 9.3.0 and will be removed in Drupal    
                    10.0.0. Use the core/once library instead. See              
                    https://www.drupal.org/node/3158256                         
--------------------------------------------------------------------------------
Check manually 0    The 'apigee_edge.app_view' library is depending on a        
                    deprecated library. The core/jquery.once asset library is   
                    deprecated in Drupal 9.3.0 and will be removed in Drupal    
                    10.0.0. Use the core/once library instead. See              
                    https://www.drupal.org/node/3158256                         
--------------------------------------------------------------------------------
Check manually 0    The 'apiproduct_access_admin' library is depending on a     
                    deprecated library. The core/jquery.once asset library is   
                    deprecated in Drupal 9.3.0 and will be removed in Drupal    
                    10.0.0. Use the core/once library instead. See              
                    https://www.drupal.org/node/3158256                         
--------------------------------------------------------------------------------

FILE: modules/contrib/apigee_edge/apigee_edge.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^8.7.7 || ^9 is not      
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

FILE:
modules/contrib/apigee_edge/modules/apigee_edge_debug/apigee_edge_debug.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^8 || ^9 is not          
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

FILE:
modules/contrib/apigee_edge/modules/apigee_edge_actions/apigee_edge_actions.info
.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^8 || ^9 is not          
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

FILE:
modules/contrib/apigee_edge/modules/apigee_edge_actions/modules/apigee_edge_acti
ons_examples/apigee_edge_actions_examples.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^8 || ^9 is not          
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

FILE:
modules/contrib/apigee_edge/modules/apigee_edge_actions/modules/apigee_edge_acti
ons_debug/apigee_edge_actions_debug.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^8 || ^9 is not          
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

FILE:
modules/contrib/apigee_edge/modules/apigee_edge_teams/apigee_edge_teams.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^8 || ^9 is not          
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

FILE:
modules/contrib/apigee_edge/modules/apigee_edge_apiproduct_rbac/apigee_edge_apip
roduct_rbac.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^8 || ^9 is not          
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

FILE: modules/contrib/apigee_edge/composer.json

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    The drupal/core requirement is not compatible with the next 
                    major version of Drupal. Either remove it or update it to be
                    compatible. See                                             
                    https://drupal.org/node/2514612#s-drupal-9-compatibility.   
--------------------------------------------------------------------------------

phdhiren · 2023-01-09T15:28:18Z

@dpagini, @VladimirAus,

Thank you for identifying the issues and sharing the information. I can create individual separate issues for each one of these changes. I will use the label "Drupal 10 Preparation" for this.

github-actions · 2023-03-12T01:54:14Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

mxr576 · 2023-04-04T09:46:44Z

@giteshk Hi, is there a timeline that you can share publicly for adding D10 compatibility to this module? Thanks in advance.

giteshk · 2023-04-04T14:53:19Z

We have started work on this, tracking to end of Q2 2023.

You will start seeing issues being created in the next 2 weeks.

Feel free to add any tickets with "Drupal 10 Preparation" label.
We love contributions from the community !

mxr576 · 2023-04-13T14:22:42Z

Thanks for the quick reply Gitesh!

We have started work on this, tracking to end of Q2 2023.

Q2 has just started, Drupal 10.0.0 is out since December 14, 2022. Drupal 9.5's support end on November 1, 2023.

These dates means to me that Drupal 10.0.x should be fairly stable now and if companies do not want to wait until the final call to upgrade their sites to security covered new major version (that also requires PHP 8.1) they should do that either in Q2 or Q3.
However, the summer holidays always interrupt Q3... so my gut says it is better to start that now.

In other words, can the Apigee team make this a higher priority?

Regarding contributions, @VladimirAus has already opened the #782. I have spent some time reviewing that back in the day but I see no other feedback on it.

janmashat · 2023-04-13T14:44:39Z

I agree with @mxr576 that customers (and vendors) should be given a chance to test the update in Q2 - because if it's postponed to Q3 then by the time things reach production we could already be in Q4 🙀

bdanin · 2023-04-13T15:33:39Z

To add the chorus here: I help maintain a large site that relies on this module, and it is the only main blocker keeping us from being able to upgrade our multi-site to Drupal 10. For us, it would be ideal if this was already a Drupal 10 release.

ChristophWeber · 2023-04-13T23:07:42Z

I will pile on as well. Any delay past Q2 will put quite a bit of strain on downstream projects. In that regard @giteshk 's update is most welcome, as is @mxr576 's comment and code review.

VladimirAus · 2023-04-13T23:30:32Z

All PRs I did for Apigee Drupal modules in the last 3 years were either stolen by internal Google team (I never got a credit) or forgotten, so no surprises here 🤷‍♂️

earth2marsh · 2023-04-14T00:14:21Z

Hey @VladimirAus , that's pretty strong language! If you're serious about your allegations of "stolen code," I'd be happy to review examples where you have some grievance, and then to address where changes might be necessary. But let's find a way to do that that doesn't pollute this issue, which is meant to address Drupal 10 compatibility?

And thanks, everyone, for your input on how important it is to enable upgrades to Drupal 10. We hear you, and it is our top priority as soon as we wrap up some improvements to how we model app ownership in Apigee X/hybrid.

If you see opportunities for how we might accelerate that by improving how community contributions get reviewed/accepted, please do offer suggestions (perhaps as a new issue or we could enable discussions for the project?). Note that in general, the bigger the PR and more files it touches, the more complicated the review will be.

VladimirAus · 2023-04-14T01:24:08Z

Hey @earth2marsh.
You can review all my PRs that were closed or ignored and then the code that is currently in the repo.
Plus I don't see any credits given on drupal.org.

mxr576 · 2023-04-14T11:49:47Z

How contributions are handled currently and what are the potential improvements in that regard is probably a side track here. Being g that said, please allow me to share my quick feedback on that: I also kept asking for reopening issues that Github Actions auto-closed because there were "no activity" on them. My personal opinion that such feature only works when there is capacity to actively check incoming issues and PRs on a project every day. Without a first response from a maintainer (which is not just an "ACK") no bot should auto-close issues. Also, instead of auto-closing them, first they should move the "stale" status. The Symfony project can be a good inspiration for configuring the bot.

(from #602)

earth2marsh · 2023-04-19T05:57:43Z

In order to keep this issue focused on Drupal 10, I enabled Discussions and started a thread where we can discuss what the most effective way to manage maintainers vs contributors should be, and another discussion for suggestions on improving contribution workflows in the project.

github-actions · 2023-06-19T01:50:35Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

janmashat · 2023-06-19T08:01:09Z

Hi, a couple months have passed here since the last comment...any chance we could get an update on the timeline for releasing a stable D10 version? Some of our customers have begun asking how long they will have for testing the D10 update - and even if Apigee releases a D10 version next week, that leaves 4 months before D9's EOL. That may seem like a lot, but we'll need to prepare, integrate, test, package and deliver before our customers can UAT and schedule deployments. That realistically leaves 2 months for UAT (which is already troubling for some customers) - and that number will quickly decrease over the coming weeks.

divya-intelli · 2023-06-19T09:36:29Z

Hi @janmashat ,
Thank you for your patience.
We will be releasing Apigee edge module for Drupal 10 next week. Currently we are testing the changes done for Drupal10 in drupal10-prep branch.

divya-intelli · 2023-07-03T15:55:27Z

Hi All,

We have released Drupal 10 compatible Apigee Edge module version 3.0.0.
@VladimirAus the changes from #782 which are pending in the README.md will be merged in separate PR(issue #880).

dpagini · 2023-07-05T16:45:41Z

@divya-intelli Thanks for the announcement here! I see the new module is only compatible with D10 (not D9), which means it can't be tested out until the whole Drupal project moves to D10. Is that a conscience decision by Apigee, or maybe an oversight? If it's compatible with D9, it would be great to see it work with both 9 and 10 versions...

divya-intelli · 2023-07-06T07:25:58Z

Hi @dpagini ,
Yes, 3.x branch is only compatible with Drupal 10. We are maintaining 3.x branch for Drupal 10 due to dependency issue (php-http/guzzle7-adapter) . To test, you will have to upgrade Drupal project to Drupal 10.
For Drupal 9 you can use 2.x branch.

divya-intelli · 2023-07-11T13:40:05Z

@dpagini ,
We will be supporting 2.x as long as Drupal 9 is supported. Changes will be applied to both the branches.

dpagini added the enhancement New feature or request label Nov 17, 2022

VladimirAus added a commit to VladimirAus/apigee-edge-drupal that referenced this issue Jan 7, 2023

[apigee#761] Updating core and php dependencies.

8bba78d

VladimirAus added a commit to VladimirAus/apigee-edge-drupal that referenced this issue Jan 7, 2023

[apigee#761] Replacing jQuery.once with core once library..

5d17678

VladimirAus added a commit to VladimirAus/apigee-edge-drupal that referenced this issue Jan 7, 2023

[apigee#761] Updated documentation.

979a1ac

VladimirAus added a commit to VladimirAus/apigee-edge-drupal that referenced this issue Jan 7, 2023

[apigee#761] Resolve getAccess depricaton.

7085a53

VladimirAus mentioned this issue Jan 7, 2023

#761 Drupal 10 compatibility #782

Closed

VladimirAus added a commit to VladimirAus/apigee-edge-drupal that referenced this issue Jan 7, 2023

[apigee#761] Added Drupal 10 testing.

f59edeb

VladimirAus added a commit to VladimirAus/apigee-edge-drupal that referenced this issue Jan 7, 2023

[apigee#761] Updated commands to Drush 11.

d24add0

This was referenced Jan 10, 2023

Relying on entity queries to check access by default is deprecated #783

Closed

The core/jquery.once asset library is deprecated #784

Closed

giteshk added the Drupal 10 Preparation label Jan 10, 2023

VladimirAus added a commit to VladimirAus/apigee-edge-drupal that referenced this issue Jan 12, 2023

[apigee#761] Dropping php dependency.

3040d7a

github-actions bot added the no-issue-activity label Mar 12, 2023

giteshk removed the no-issue-activity label Mar 12, 2023

giteshk pushed a commit to giteshk-org/apigee-edge-drupal that referenced this issue Apr 14, 2023

[apigee#761] Updating core and php dependencies.

4e46157

giteshk pushed a commit to giteshk-org/apigee-edge-drupal that referenced this issue Apr 14, 2023

[apigee#761] Replacing jQuery.once with core once library..

203d126

giteshk pushed a commit to giteshk-org/apigee-edge-drupal that referenced this issue Apr 14, 2023

[apigee#761] Updated documentation.

16e6b98

giteshk pushed a commit to giteshk-org/apigee-edge-drupal that referenced this issue Apr 14, 2023

[apigee#761] Resolve getAccess depricaton.

1dceb9d

giteshk pushed a commit to giteshk-org/apigee-edge-drupal that referenced this issue Apr 14, 2023

[apigee#761] Added Drupal 10 testing.

c693214

giteshk pushed a commit to giteshk-org/apigee-edge-drupal that referenced this issue Apr 14, 2023

[apigee#761] Updated commands to Drush 11.

6f36cf9

mxr576 mentioned this issue May 8, 2023

Drupal 10 readiness apigee/apigee-m10n-drupal#430

Closed

This was referenced May 31, 2023

Bumped version for Drupal10 support #844

Merged

Bump version for Drupal 10 Support #847

Closed

Javascript Deprecation: jQuery.once() is deprecated in Drupal 9.3 #850

Closed

github-actions bot added the no-issue-activity label Jun 19, 2023

divya-intelli removed the no-issue-activity label Jun 19, 2023

divya-intelli closed this as completed Aug 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drupal 10 compatibility. #761

Drupal 10 compatibility. #761

dpagini commented Nov 17, 2022

VladimirAus commented Jan 7, 2023

phdhiren commented Jan 9, 2023

github-actions bot commented Mar 12, 2023

mxr576 commented Apr 4, 2023

giteshk commented Apr 4, 2023

mxr576 commented Apr 13, 2023 •

edited

janmashat commented Apr 13, 2023

bdanin commented Apr 13, 2023

ChristophWeber commented Apr 13, 2023

VladimirAus commented Apr 13, 2023 •

edited

earth2marsh commented Apr 14, 2023

VladimirAus commented Apr 14, 2023

mxr576 commented Apr 14, 2023

earth2marsh commented Apr 19, 2023

github-actions bot commented Jun 19, 2023

janmashat commented Jun 19, 2023 •

edited

divya-intelli commented Jun 19, 2023

divya-intelli commented Jul 3, 2023 •

edited

dpagini commented Jul 5, 2023

divya-intelli commented Jul 6, 2023

divya-intelli commented Jul 11, 2023

Drupal 10 compatibility. #761

Drupal 10 compatibility. #761

Comments

dpagini commented Nov 17, 2022

Is your feature request related to a problem? Please describe.

Describe the solution you would like

Describe alternatives you have considered

Additional context

VladimirAus commented Jan 7, 2023

Result

phdhiren commented Jan 9, 2023

github-actions bot commented Mar 12, 2023

mxr576 commented Apr 4, 2023

giteshk commented Apr 4, 2023

mxr576 commented Apr 13, 2023 • edited

janmashat commented Apr 13, 2023

bdanin commented Apr 13, 2023

ChristophWeber commented Apr 13, 2023

VladimirAus commented Apr 13, 2023 • edited

earth2marsh commented Apr 14, 2023

VladimirAus commented Apr 14, 2023

mxr576 commented Apr 14, 2023

earth2marsh commented Apr 19, 2023

github-actions bot commented Jun 19, 2023

janmashat commented Jun 19, 2023 • edited

divya-intelli commented Jun 19, 2023

divya-intelli commented Jul 3, 2023 • edited

dpagini commented Jul 5, 2023

divya-intelli commented Jul 6, 2023

divya-intelli commented Jul 11, 2023

mxr576 commented Apr 13, 2023 •

edited

VladimirAus commented Apr 13, 2023 •

edited

janmashat commented Jun 19, 2023 •

edited

divya-intelli commented Jul 3, 2023 •

edited