Fix for Test & Lint Functional Errors #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kedarkhaire
changed the title
giteshk
approved these changes
Feb 29, 2024
This was referenced Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #473, #474 & #477
The changes are made in testcases because in commerce module it takes all the integer, float, decimal, string values as a string only - https://docs.drupalcommerce.org/commerce2/developer-guide/pricing/prices
Boolean values True & False are accepted, they don't need to be converted.
Changes made in AddCreditAddToCartForm.php file is made as per the recent changes made in AddtoCart.php file from Commerce Cart module v2.36 to v2.37.
Instead of redefining the variables and missing any other, we use parent::create($container), this has all the required things for AddtoCart commerce cart functionality.
Additional variables & objects can be defined in create using container and defining it to the instance created.