Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed deprecated commands and the 'token' field from /token response #143

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

rockspore
Copy link
Contributor

Fix #105

token field is removed from the remote-service/token endpoint following OAuth2 spec. bindings add/remove/verify are removed.

Since upgrading Envoy V3 APIs involves breaking change. This PR can be merged in the same release.

@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #143 (81d6fda) into master (60dc389) will increase coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
+ Coverage   79.55%   79.82%   +0.27%     
==========================================
  Files          16       16              
  Lines        1898     1755     -143     
==========================================
- Hits         1510     1401     -109     
+ Misses        203      186      -17     
+ Partials      185      168      -17     
Impacted Files Coverage Δ
cmd/bindings/bindings.go 75.82% <ø> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60dc389...81d6fda. Read the comment docs.

@rockspore rockspore marked this pull request as ready for review January 20, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.x deprecations
2 participants