Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double wildcard will match zero segments at the end of a path #109

Merged
merged 2 commits into from
Nov 3, 2021

Conversation

rockspore
Copy link
Contributor

@rockspore rockspore commented Nov 3, 2021

fix #108

@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #109 (b9e61c0) into master (0cff34b) will increase coverage by 1%.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #109   +/-   ##
=====================================
+ Coverage      85%    85%   +1%     
=====================================
  Files          29     29           
  Lines        1757   1760    +3     
=====================================
+ Hits         1490   1493    +3     
  Misses        153    153           
  Partials      114    114           
Impacted Files Coverage Δ
path/tree.go 98% <100%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cff34b...b9e61c0. Read the comment docs.

@theganyo
Copy link
Member

theganyo commented Nov 3, 2021

Why does this have the logging fix in it?

@rockspore
Copy link
Contributor Author

Why does this have the logging fix in it?

Sorry, forgot to rebase the branch. Done.

@theganyo
Copy link
Member

theganyo commented Nov 3, 2021

Should we have a similar test for extracting the variable? Eg. /c/{var=**}/x?

@rockspore
Copy link
Contributor Author

Should we have a similar test for extracting the variable? Eg. /c/{var=**}/x?

Makes a lot of sense! Added those.

@rockspore rockspore merged commit b161ad5 into master Nov 3, 2021
@rockspore rockspore deleted the issue-102 branch November 3, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double wildcard not matching zero segment
2 participants