Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed records_size to records_batch_size #113

Closed
wants to merge 1 commit into from
Closed

Conversation

rockspore
Copy link
Contributor

Close #112

Not merging this time till metrics got approved.

@rockspore rockspore added this to the EG4A milestone Nov 18, 2021
@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #113 (0027bcb) into master (9be01f4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #113   +/-   ##
=====================================
  Coverage      85%    85%           
=====================================
  Files          29     29           
  Lines        1760   1760           
=====================================
  Hits         1493   1493           
  Misses        153    153           
  Partials      114    114           
Impacted Files Coverage Δ
analytics/manager.go 84% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9be01f4...0027bcb. Read the comment docs.

@rockspore
Copy link
Contributor Author

No need to have this renaming. We can do a mapping somewhere else.

@rockspore rockspore closed this Dec 1, 2021
@rockspore rockspore deleted the issue-112 branch December 1, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename the analytics_records_count metric
1 participant