Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove go-multierror lib #64

Merged
merged 3 commits into from
Mar 24, 2021
Merged

remove go-multierror lib #64

merged 3 commits into from
Mar 24, 2021

Conversation

theganyo
Copy link
Member

Fixes #63

@theganyo theganyo requested a review from rockspore March 24, 2021 18:44
@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #64 (f48d7f1) into master (3355f79) will increase coverage by 1%.
The diff coverage is 84%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #64   +/-   ##
=====================================
+ Coverage      84%    84%   +1%     
=====================================
  Files          27     28    +1     
  Lines        1610   1632   +22     
=====================================
+ Hits         1346   1368   +22     
  Misses        148    148           
  Partials      116    116           
Impacted Files Coverage Δ
analytics/recovery.go 49% <0%> (ø)
analytics/staging.go 76% <0%> (ø)
analytics/record.go 87% <100%> (ø)
errorset/errorset.go 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3355f79...f48d7f1. Read the comment docs.

errorset/errorset.go Outdated Show resolved Hide resolved
@theganyo theganyo merged commit 9e03f80 into master Mar 24, 2021
@theganyo theganyo deleted the theganyo/issue63 branch March 24, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove go-multierror lib
2 participants