Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCP SF: adding expiry timeout property for cache population #145

Merged
merged 4 commits into from
Jan 8, 2021
Merged

GCP SF: adding expiry timeout property for cache population #145

merged 4 commits into from
Jan 8, 2021

Conversation

danistrebel
Copy link
Collaborator

What's changed, or what was fixed?

  • hybrid runtime now requires a cache expiration to be specified (Policy validation currently only accepts TimeoutInSec and not TimeoutInSeconds)

Fixes: #144

  • I have run all the tests locally and they all pass.
  • I have followed the relevant style guide for my changes.

CC: @apigee-devrel-reviewers

@seymen
Copy link
Collaborator

seymen commented Jan 7, 2021

updating the branch with the recent changes in the main

@seymen seymen merged commit 0b2a45a into apigee:main Jan 8, 2021
@danistrebel danistrebel deleted the fix/gcp-sa-timeout branch January 25, 2021 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seymen seymen seymen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danistrebel @seymen