Skip to content
This repository has been archived by the owner on May 27, 2022. It is now read-only.

Commit

Permalink
Fixed wording to be more explicit
Browse files Browse the repository at this point in the history
One has to assume the original file uploaded (the very first time) is
the right and canonical version. If files change somehow it's most
likely to be a disk corruption issue
  • Loading branch information
thekad committed Sep 5, 2012
1 parent eaf5515 commit e827100
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions tablesnap
Expand Up @@ -124,8 +124,10 @@ class UploadHandler(pyinotify.ProcessEvent):

if key.size != stat.st_size:
log.warning('ATTENTION: your source (%s) and target (%s) sizes '
'differ, you should take a look. Will skip this file to '
'avoid future complications' % (filename, keyname, ))
'differ, you should take a look. As immutable files '
'never change, one must assume the local file got corrupted '
'and the right version is the one in S3. Will skip this file '
'to avoid future complications' % (filename, keyname, ))
return True
else:
# Compute MD5 sum of file
Expand Down Expand Up @@ -159,7 +161,9 @@ class UploadHandler(pyinotify.ProcessEvent):
log.info("Keyname %s already exists, skipping upload" % keyname)
else:
log.warning('ATTENTION: your source (%s) and target (%s) MD5 '
'hashes differ, you should take a look. Will skip this file '
'hashes differ, you should take a look. As immutable files '
'never change, one must assume the local file got corrupted '
'and the right version is the one in S3. Will skip this file '
'to avoid future complications' % (filename, keyname, ))
return True

Expand Down

0 comments on commit e827100

Please sign in to comment.