Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove "iconv-lite" emulation #81

Closed
gbrail opened this issue Aug 26, 2014 · 0 comments
Closed

remove "iconv-lite" emulation #81

gbrail opened this issue Aug 26, 2014 · 0 comments
Labels
bug code complete

Comments

@gbrail
Copy link
Contributor

gbrail commented Aug 26, 2014

trireme-utils contains an implementation of "iconv-lite" that is incomplete, which causes problems with the latest Connect middleware.

iconv-lite is pure JavaScript and should work fine. It was added long ago when we were unable to handle scripts larger than 64K (we do this today by running them in interpreted mode).

There is also an implementation of "iconv" in there that we should retain because "iconv" relies on binary code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug code complete
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gbrail