This repository has been archived by the owner on Sep 2, 2022. It is now read-only.
Send user's IP address with metrics #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 127 128 +1
Branches 11 11
=========================================
+ Hits 127 128 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
ruohola
force-pushed
the
send-geo-ip
branch
2 times, most recently
from
28671c2
to
58ffacd
Compare
ruohola
changed the title
Used for visualization aggregate geolocation data. The IP is never stored, and it is never sent to 3rd parties. We read the IP from the `X-Forwarded-For` header since in production one's backend service is most likely behind a reverse proxy of some sort. We use the left-most value in case there are multiple IPs in it, since that's most likely not from "our" infra and we don't have to worry about spoofing too much because it's not used for anything security related. Some additional reading about getting the real IP address: https://adam-p.ca/blog/2022/03/x-forwarded-for/
blomqma
approved these changes
Mar 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used for visualization aggregate geolocation data. The IP is never
stored, and it is never sent to 3rd parties.
We read the IP from the
X-Forwarded-Forheader since in productionone's backend service is most likely behind a reverse proxy of some
sort. We use the left-most value in case there are multiple IPs in it,
since that's most likely not from "our" infra and we don't have to worry
about spoofing too much because it's not used for anything security
related.
Some additional reading about getting the real IP address:
https://adam-p.ca/blog/2022/03/x-forwarded-for/