Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.

Send user's IP address with metrics #19

Merged
merged 2 commits into from Mar 17, 2022
Merged

Send user's IP address with metrics #19

merged 2 commits into from Mar 17, 2022

Commits on Mar 17, 2022

  1. Add a note about empty strings to user_agent param

    @ruohola
    ruohola committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    0078fe8 View commit details
    Browse the repository at this point in the history

  2. Send user's IP address with metrics 

    Used for visualization aggregate geolocation data. The IP is never
stored, and it is never sent to 3rd parties.

We read the IP from the `X-Forwarded-For` header since in production
one's backend service is most likely behind a reverse proxy of some
sort. We use the left-most value in case there are multiple IPs in it,
since that's most likely not from "our" infra and we don't have to worry
about spoofing too much because it's not used for anything security
related.

Some additional reading about getting the real IP address:
https://adam-p.ca/blog/2022/03/x-forwarded-for/
    @ruohola
    ruohola committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    5c29d99 View commit details
    Browse the repository at this point in the history