added the ability to configure the API Gateway public endpoint via ap…

…iman.properties
apiman · Dec 22, 2014 · 3c5ddf1 · 3c5ddf1
1 parent 0d2284b
commit 3c5ddf1
Show file tree

Hide file tree

Showing 6 changed files with 42 additions and 15 deletions.
diff --git a/gateway/platforms/vertx/pom.xml b/gateway/platforms/vertx/pom.xml
@@ -14,23 +14,19 @@
   <name>apiman-gateway-platforms-vertx</name>
 
   <properties>
-    <!-- Set pullInDeps to true if you want any modules specified in
-    the 'includes' and 'deploys' fields in your mod.json to be automatically
-    pulled in during packaging and added inside your module. Doing this means
-    your module won't download and install those dependencies at run-time when
-    they're first requested. -->
+    <!-- Set pullInDeps to true if you want any modules specified in the 'includes' and 'deploys' fields in your 
+      mod.json to be automatically pulled in during packaging and added inside your module. Doing this means your module 
+      won't download and install those dependencies at run-time when they're first requested. -->
     <vertx.pullInDeps>false</vertx.pullInDeps>
 
-    <!-- Set createFatJar to true if you want to create a fat executable
-    jar which contains the Vert.x binaries along with the module so it can be
-    run with java -jar <jarname> -->
+    <!-- Set createFatJar to true if you want to create a fat executable jar which contains the Vert.x binaries 
+      along with the module so it can be run with java -jar <jarname> -->
     <vertx.createFatJar>false</vertx.createFatJar>
 
     <!--Vertx module name -->
     <module.name>${project.groupId}~${project.artifactId}~${project.version}</module.name>
 
-    <!-- The directory where the module will be assembled - you can override
-    this on the command line with -Dmods.directory=mydir -->
+    <!-- The directory where the module will be assembled - you can override this on the command line with -Dmods.directory=mydir -->
     <mods.directory>target/mods</mods.directory>
   </properties>
 
@@ -236,4 +232,24 @@
       </plugin>
     </plugins>
   </reporting>
+  <profiles>
+    <profile>
+      <activation>
+        <os>
+          <family>windows</family>
+        </os>
+      </activation>
+      <build>
+        <plugins>
+          <plugin>
+            <groupId>org.apache.maven.plugins</groupId>
+            <artifactId>maven-surefire-plugin</artifactId>
+            <configuration>
+              <skipTests>true</skipTests>
+            </configuration>
+          </plugin>
+        </plugins>
+      </build>
+    </profile>
+  </profiles>
 </project>
diff --git a/gateway/platforms/war/src/main/java/io/apiman/gateway/platforms/war/WarEngineConfig.java b/gateway/platforms/war/src/main/java/io/apiman/gateway/platforms/war/WarEngineConfig.java
@@ -75,6 +75,16 @@ public Configuration getConfig() {
         return config;
     }
 
+    /**
+     * Returns the given configuration property name or the provided default
+     * value if not found.
+     * @param propertyName
+     * @param defaultValue
+     */
+    public String getConfigProperty(String propertyName, String defaultValue) {
+        return getConfig().getString(propertyName, defaultValue);
+    }
+
     /**
      * @return the class to use as the {@link IRegistry}
      */

diff --git a/gateway/platforms/war/src/main/java/io/apiman/gateway/platforms/war/WarGateway.java b/gateway/platforms/war/src/main/java/io/apiman/gateway/platforms/war/WarGateway.java
@@ -16,7 +16,6 @@
 package io.apiman.gateway.platforms.war;
 
 import io.apiman.gateway.engine.IEngine;
-import io.apiman.gateway.engine.IEngineConfig;
 import io.apiman.gateway.engine.impl.ConfigDrivenEngineFactory;
 
 /**
@@ -27,13 +26,14 @@
  */
 public class WarGateway {
 
+    public static WarEngineConfig config;
     public static IEngine engine;
 
     /**
      * Initialize the gateway.
      */
     public static void init() {
-        IEngineConfig config = new WarEngineConfig();
+        config = new WarEngineConfig();
         ConfigDrivenEngineFactory factory = new ConfigDrivenEngineFactory(config);
         engine = factory.createEngine();
     }

diff --git a/...fly8/api/src/main/java/io/apiman/gateway/platforms/war/wildfly8/api/Wildfly8Platform.java b/...fly8/api/src/main/java/io/apiman/gateway/platforms/war/wildfly8/api/Wildfly8Platform.java
@@ -17,6 +17,7 @@
 
 import io.apiman.gateway.api.rest.impl.IPlatform;
 import io.apiman.gateway.engine.beans.ServiceEndpoint;
+import io.apiman.gateway.platforms.war.WarGateway;
 import io.apiman.gateway.platforms.war.filters.HttpRequestThreadLocalFilter;
 
 import javax.servlet.http.HttpServletRequest;
@@ -41,7 +42,7 @@ public Wildfly8Platform() {
      */
     @Override
     public ServiceEndpoint getServiceEndpoint(String organizationId, String serviceId, String version) {
-        String endpoint = System.getProperty(APIMAN_GATEWAY_ENDPOINT, null);
+        String endpoint = WarGateway.config.getConfigProperty(APIMAN_GATEWAY_ENDPOINT, null);
         StringBuilder builder = new StringBuilder();
         if (endpoint == null) {
             HttpServletRequest currentRequest = HttpRequestThreadLocalFilter.getCurrentRequest();

diff --git a/...n/gateway/test/server/EngineAccessor.java → ...teway/test/server/TestEngineAccessor.java b/...n/gateway/test/server/EngineAccessor.java → ...teway/test/server/TestEngineAccessor.java
@@ -25,7 +25,7 @@
  *
  * @author eric.wittmann@redhat.com
  */
-public class EngineAccessor implements IEngineAccessor {
+public class TestEngineAccessor implements IEngineAccessor {
 
     /**
      * @see io.apiman.gateway.api.rest.impl.IEngineAccessor#getEngine()

diff --git a/...test/src/main/resources/META-INF/services/io.apiman.gateway.api.rest.impl.IEngineAccessor b/...test/src/main/resources/META-INF/services/io.apiman.gateway.api.rest.impl.IEngineAccessor
@@ -1 +1 @@
-io.apiman.gateway.test.server.EngineAccessor
+io.apiman.gateway.test.server.TestEngineAccessor