APIMAN-480 Add <finalName> tag to all poms using war packaging #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To aid in IDE/server integration, it is extremely helpful if projects that generate wars create war artifacts named to match the intended target context names.
|
GIve this a whirl Eric. I don't see any negative side effects. Is there any chance this could impact your release process? |
|
I will give this a try asap, thanks. I don't think it should be an issue. |
|
We could also define these final war names as properties in the root pom. This would help with maintenance down the road if the context names were to change. Up to you. |
EricWittmann
added a commit
that referenced
this pull request
Jun 16, 2015
APIMAN-480 Add <finalName> tag to all poms using war packaging
|
Thanks. No need to pull the names up as properties I don't think. We can do that later if there becomes a compelling reason for it. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To aid in IDE/server integration, it is extremely helpful if projects that generate wars create war artifacts named to match the intended target context names.