Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix host problem in vertx3 port #187

Closed
wants to merge 1 commit into from

Conversation

msavy
Copy link
Member

@msavy msavy commented Aug 21, 2015

No description provided.

@msavy
Copy link
Member Author

msavy commented Aug 21, 2015

Weirdly this didn't fail on my machine, but I probably didn't do a full clean install from the root.

The reason this is happening is because I added the eb-inmemory engine to vert.x 3, and it has introduced a cyclical dependency issue. I would like this to be available, though, because it's handy to have as a dumb test-it-out setup for blogs, etc.

I guess I might have to refactor and put some stuff in vert.x3-common (or whatever), which is a bit of a pain as it's nice having everything compact.

@EricWittmann
Copy link
Member

So should I merge them? I guess not?

@msavy
Copy link
Member Author

msavy commented Aug 21, 2015

No
On 21 Aug 2015 23:18, "Eric Wittmann" notifications@github.com wrote:

So should I merge them? I guess not?


Reply to this email directly or view it on GitHub.

@msavy msavy closed this Aug 21, 2015
@msavy
Copy link
Member Author

msavy commented Aug 21, 2015

Will work to fix them before Monday
On 21 Aug 2015 23:19, "Marc Savy" marc@rhymewithgravy.com wrote:

No
On 21 Aug 2015 23:18, "Eric Wittmann" notifications@github.com wrote:

So should I merge them? I guess not?


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants