Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re # 752 753 Improvements and minor fixes for clipboard copy #258

Merged
merged 1 commit into from Oct 29, 2015

Conversation

kahboom
Copy link
Member

@kahboom kahboom commented Oct 29, 2015

Changes:

  • Upgrade Patternfly to latest version; update Browserify entry.js and Gruntfile.js accordingly.
  • Add inline button and icon for copy button.
  • Add tooltip on hovering over copy button, which will update on click. On mouseleave, the tooltip will reset as requested in issue 753.
  • Add reusable directive for tooltips.
  • Add code for tooltip & copy feature in app API controller & HTML, though temporarily commented out since there seems to be a bug with ng-repeat and the clipboard library. Will be opening an issue in the library GH repo.
  • Add a tooltip.d.ts file to resolve an issue with jQuery & TS not working well together.

Issues:

To resolve issue 752, I think we should try to use another clipboard library, which should be very easy to change. Will come back to this issue later today to give that a shot.

cc @EricWittmann

EricWittmann added a commit that referenced this pull request Oct 29, 2015
re # 752 753 Improvements and minor fixes for clipboard copy
@EricWittmann EricWittmann merged commit 11763ce into apiman:master Oct 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants