#861 Fix for inability to save API definition #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <span ng-bind="type.label"></span> | ||
| </ui-select-choices> | ||
| </ui-select> | ||
| <select apiman-i18n-key="api-def.choose-type" title="Choose a type..." apiman-select-picker="" ng-model="selectedDefinitionType" class="selectpicker" ng-options="type.label for type in typeOptions track by type.value"> |
There was a problem hiding this comment.
I think this <select> box needs the ng-disabled="isEntityDisabled()" attribute included on it.
|
@EricWittmann - Done. Added |
EricWittmann
added a commit
that referenced
this pull request
Dec 23, 2015
#861 Fix for inability to save API definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this is a blocking issue I just decided to revert the addition of UI-Select for this page.
I may be getting a little overeager here in trying to switch to UI-Select, but as I'm diving in, this switch is more problematic for some views than others. It seems like there are many
$watch's that are also integrated with other functionality, such as dirty checking and sometimes state setting.While I'd prefer to have a cleaner implementation of these features, I know it's certainly not ideal nor efficient to rewrite these on the go, especially without testing in place. I think we should still switch to UI-Select, but it may be a while before we can transition completely.
JIRA: https://issues.jboss.org/browse/APIMAN-861
cc @EricWittmann