Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for APIMAN-942 - Ability to delete an unpublished service. #347

Merged
merged 1 commit into from Feb 1, 2016

Conversation

ctsantiago
Copy link

This is a proposed change described in:
https://issues.jboss.org/browse/APIMAN-942

@EricWittmann
Copy link
Member

This is a great start, thanks!

Note: I am going to make the following changes to this PR:

  • The endpoint to DELETE an API:
    @DELETE
    @Path("{organizationId}/apis/{apiId}")
    public void deleteApi(@PathParam("organizationId") String organizationId,
            @PathParam("apiId") String apiId)
            throws ApiNotFoundException, NotAuthorizedException, InvalidApiStatusException;
  • The user will need to have the "apiAdmin" privilege to delete, rather than full Admin privs

@EricWittmann EricWittmann merged commit b314dc8 into apiman:master Feb 1, 2016
@EricWittmann
Copy link
Member

OK @ctsantiago - merged and modified. Please have a look and let me know if the solution still works for you! :)

@ctsantiago
Copy link
Author

Thanks Eric. I learned a lot from your changes for next time. This works for us.

@EricWittmann
Copy link
Member

OK great! I think there is still work to be done on the Delete API feature - but it should be a good start. For example, I'd like it to work provided there are no published APIs. But that means when an API is retired we need to break all its contracts. Or else we need to break the contracts when deleting it (that's probably the way to go).

But for now this gets us some common use cases (e.g. I created an API and never published it, but now I can't delete it!). :)

We also still need to work on deleting Plans, Orgs, and Clients. Again, I think this PR is a good start to all that work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants