re #992 Switch from TSD to Typings

[kahboom]

Changes:

• Remove typings dir and tsd.json file locally.
• Uninstall TSD, install Typings.
• Upgrade TSD JSON file to Typings JSON file.
• Remove TSD JSON file.
• Remove gulp-tsd package, Gulp 'setup' task, instead ask NPM to use TS binary to install TS definitions.
• Rewrite npm-shrinkwrap.json file.
• Update Gulp to 3.9.1 latest patch.

JIRA: https://issues.jboss.org/browse/APIMAN-992

cc @EricWittmann @msavy - Tested on OS X and everything looked good, but please let me know if you run into anything strange. Locally, you should be safe to delete the typings dir and tsd.json file. You may need to run rm -rf node_modules & npm install.

[msavy]

I thought we were committing all of the TSD dips into the repo? This was one of the prod requirements.

Can we achieve this?

E.g. install TSD with typings, then commit installed definitions to the repo; presumably we could then point our build to aforementioned directory (or use typings and refer it to that directory?)

On 23 Feb 2016, at 19:14, Rachel Yordán notifications@github.com wrote:

Changes:

Remove typings dir and tsd.json file locally.
Uninstall TSD, install Typings.
Upgrade TSD JSON file to Typings JSON file.
Remove TSD JSON file.
Remove gulp-tsd package, Gulp 'setup' task, instead ask NPM to use TS binary to install TS definitions.
Rewrite npm-shrinkwrap.json file.
Update Gulp to 3.9.1 latest patch.
JIRA: https://issues.jboss.org/browse/APIMAN-992 https://issues.jboss.org/browse/APIMAN-992
cc @EricWittmann https://github.com/EricWittmann @msavy https://github.com/msavy - Tested on OS X and everything looked good, but please let me know if you run into anything strange. Locally, you should be safe to delete the typings dir and tsd.json file. You may need to run rm -rf node_modules & npm install.

You can view, comment on, or merge this pull request online at:

#415 #415
Commit Summary

re #992 Switch from TSD to Typings
File Changes

M manager/ui/war/gulpfile.js https://github.com/apiman/apiman/pull/415/files#diff-0 (15)
M manager/ui/war/npm-shrinkwrap.json https://github.com/apiman/apiman/pull/415/files#diff-1 (1290)
M manager/ui/war/package.json https://github.com/apiman/apiman/pull/415/files#diff-2 (6)
M manager/ui/war/plugins/includes.ts https://github.com/apiman/apiman/pull/415/files#diff-3 (2)
D manager/ui/war/tsd.json https://github.com/apiman/apiman/pull/415/files#diff-4 (21)
A manager/ui/war/typings.json https://github.com/apiman/apiman/pull/415/files#diff-5 (9)
Patch Links:

https://github.com/apiman/apiman/pull/415.patch https://github.com/apiman/apiman/pull/415.patch
https://github.com/apiman/apiman/pull/415.diff https://github.com/apiman/apiman/pull/415.diff
—
Reply to this email directly or view it on GitHub #415.

[kahboom]

@msavy - Why were we looking to check in TS definitions again? Was this in order to make 100% offline installations possible (ie. to avoid the GH rate-limiting issue)? And np I'll commit the typings dir and remove it from .gitignore. We are already committing the typings-custom dir.

[msavy]

It’s related to prod and their current lack of tooling to handle Typings.

On 23 Feb 2016, at 19:51, Rachel Yordán notifications@github.com wrote:

@msavy https://github.com/msavy - Why were we looking to check in TS definitions again? Was this in order to make 100% offline installations possible (ie. to avoid the GH rate-limiting issue)? And np I'll commit the typings dir and remove it from .gitignore. We are already committing the typings-custom dir.

—
Reply to this email directly or view it on GitHub #415 (comment).

[EricWittmann]

@kahboom - yes, the reason to check in the TSD files is so that prod builds don't have to download them.

Let me know when this is ready to be merged based on marc's feedback.

[kahboom]

@EricWittmann @msavy - Done! Let me know if I missed anything.