re #996 Delete APIs in UI #427
Conversation
| modalInstance.result.then(function (selectedItem) { | ||
| $scope.selected = selectedItem; | ||
| }, function () { | ||
| $log.info('Modal dismissed at: ' + new Date()); |
There was a problem hiding this comment.
Don't use $log - instead use Logger, which is already being injected.
|
This looks really great! Nice job. Does it actually work?! :) |
|
@EricWittmann - Well, I get a "method not allowed" error when trying to delete, if that's what you mean (see screenshot below). I couldn't test this with mock requests because I don't have unit tests set up, and the backend isn't ready yet. Or should this request have succeeded? I tested manually with a published API and an API that has never been published before (with only one version).
|
|
Ah yes I see - you're not sending the correct REST request. You're sending a request here: Instead, you want to send the DELETE request here: I believe it should work. |
|
Wow lol, thanks. On Thu, Mar 3, 2016 at 7:39 AM, Eric Wittmann notifications@github.com
|
kahboom
force-pushed
the
996-delete-apis
branch
2 times, most recently
from
85b70ef
to
5333c31
Compare
re apiman#1001 Quick fix for How to Invoke API modal close button not working Update API method re apiman#996 Use Logger instead of ; log cleanup; use proper method to close modal
|
Sorry - I was waiting for this to be updated with the proper REST api call. You did update it but I didn't get a notification of that change. So now it's merged! |
Changes:
Also, in the future we need to implement a check that determines whether to show/hide the delete button at all in the UI. For now, the user will know because they will get an error when they try to delete an "undeletable" API.
Screenshots:
JIRA: https://issues.jboss.org/browse/APIMAN-996
cc @EricWittmann @msavy