Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APIMAN-883] [APIMAN-890] [APIMAN-942] Delete feature (Org, API and ClientApp) #446

Merged
merged 6 commits into from Apr 8, 2016

Conversation

msavy
Copy link
Member

@msavy msavy commented Apr 6, 2016

Just been doing tonnes of tidying up (and squashing away a huge number of failed intermediary attempts!).

Please take a look @apiman/developers !

@msavy
Copy link
Member Author

msavy commented Apr 6, 2016

Oh darn, I just realised I forgot to check for permissions. I'll definitely need to do that.

What are we thinking? Administrator?

@msavy
Copy link
Member Author

msavy commented Apr 6, 2016

@KurtStam This may interest you. The interface is (roughly):

DELETE organizations/{organizationId}
DELETE organizations/{organizationId}/clients/{clientId}
DELETE organizations/{organizationId}/apis/{apiId}

Note that in order for a delete to be allowed a given entity must not be active. For instance, you can't delete an API if there are any published versions (retire any that are).

@msavy msavy changed the title For Review: Delete feature (org, api and clientapp) [APIMAN-883] [APIMAN-890] [APIMAN-942] Delete feature (Org, API and ClientApp) Apr 7, 2016
@@ -95,6 +95,7 @@ protected void commitTx() throws StorageException {
throw new StorageException(e);
} catch (RollbackException e) {
logger.error(e.getMessage(), e);
e.printStackTrace(System.err);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. I'll remove these.

@msavy
Copy link
Member Author

msavy commented Apr 8, 2016

🚢 Should be good now.

@EricWittmann EricWittmann merged commit 8fbf04f into apiman:master Apr 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants