Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apiman 182 #46

Merged
merged 3 commits into from Dec 29, 2014
Merged

Apiman 182 #46

merged 3 commits into from Dec 29, 2014

Conversation

ruromero
Copy link
Contributor

Added DDL generated by Hibernate and latest jdbc driver for postgres along with a sample configuration of the datasource.

In order to work with the sequences I found that the IDENTITY strategy had to be used.

To make the configuration work I had to add the module and the jdbc-driver to wildfly. This can be done either manually or through the jboss-cli. In my case I preferred the last option. Here follows the commands used:

module add --name=org.postgresql --resources=/tmp/postgresql-9.3-1102.jdbc41.jar --dependencies=javax.api,javax.transaction.api /subsystem=datasources/jdbc-driver=postgresql-9.3-1102.jdbc41.jar_org.postgresql.Driver_9_3:add(driver-name="postgresql-9.3-1102.jdbc41.jar_org.postgresql.Driver_9_3",driver-module-name="org.postgresql",driver-class-name=org.postgresql.Driver

@EricWittmann
Copy link
Member

This looks really good, thanks @discolo! Can you make a couple of additional changes before I merge this?

  • Give the FK constraints better names (currently it's just using the hibernate generated ones - which work but are a little strange to see in a curated DDL)
  • Add in the Indexes that are defined in the mysql DDL (after each table in the DDL are 0 or more indexes defined for that table)

@ruromero
Copy link
Contributor Author

Done! Thanks for the feedback. I've also reordered the creation tables the same way as in the mysql ddl.

EricWittmann added a commit that referenced this pull request Dec 29, 2014
@EricWittmann EricWittmann merged commit 1223088 into apiman:master Dec 29, 2014
@EricWittmann
Copy link
Member

Nice work, thanks!

@ruromero ruromero deleted the apiman-182 branch December 29, 2014 17:56
msavy pushed a commit that referenced this pull request Jan 5, 2023
msavy pushed a commit that referenced this pull request Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants