Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re #1135 #1108 Fix for bug with saving API gateway in UI #466

Merged
merged 1 commit into from Apr 30, 2016

Conversation

kahboom
Copy link
Member

@kahboom kahboom commented Apr 29, 2016

Issue(s):

JIRA 1: https://issues.jboss.org/browse/APIMAN-1135
JIRA 2: https://issues.jboss.org/browse/APIMAN-1108

There were two bugs occurring:

  1. Regardless of whether you have a single gateway or multiple, the save button in the Implementation tab is disabled unless the endpoint field is dirtied. This is a bug because it should not be checking if the field is dirty, rather that there is a valid value there at all. For instance, if you were to add an endpoint, save it, and then add the gateway after, the save button would still be disabled unless you dirtied the endpoint field.
  2. Assuming you did dirty the endpoint field, the save button would become enabled, but upon pressing the save button, the gateway information is not retained or persisted. You will still see the error message in the Implementation tab if you had no gateways selected before, and in either case you'd still see that you have not selected a gateway in the 'Why Can't I Publish?' checklist.

Changes:

  • Lodash's pluck method was deprecated, switched to use map instead.
  • Minor changes such as semantics and spacing of HTML.

cc @EricWittmann @msavy

Notes:

Currently, users are allowed to create the API, define the endpoint, etc. without having a gateway configured. They can go back, add the gateway, and continue configuring the API before publishing it. They can also "trick" the application so that if they unselect all gateways (if they have multiple) and then make the endpoint field "dirty", the save button will become enabled. So, if you were to press save and go back, it will just have the dropdown selection as 'Nothing selected'. They can then select whatever gateway they want. Spoke with @EricWittmann and this should be fine for now, but we can reevaluate this behavior at a later time. This is shown in the screenshots below.

Screenshots:

Screencast: https://drive.google.com/open?id=0B9yOpcUD9qIaelhiaWFpMGNtOEU

The screenshots are not as illustrative as the screencast, so I'd recommend watching that instead.

User deselects both gateways configured, presses save, navigates away and then comes back to the Implementations tab:
screen shot 2016-04-29 at 3 38 11 pm

Showing that we have more than one gateway, and that selecting one now enables the save button without having to "dirty" the endpoint field:
screen shot 2016-04-29 at 3 38 26 pm

We have now saved one of our configured gateways, and this value is retained when navigating between tabs:
screen shot 2016-04-29 at 3 38 34 pm

@kahboom kahboom changed the title re #1135 #1108 Fix for multiple API gateway bugs in UI re #1135 #1108 Fix for bug with saving API gateway in UI Apr 29, 2016
@EricWittmann EricWittmann merged commit d4574e2 into apiman:master Apr 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants