re #1169 Switch to UI-Bootstrap Modals #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to UI bootstrap for New Contract page Fix for opening modal Switch to UI Bootstrap modal for Client Contracts entity ctrl Fix for Client view Client policies and contracts UI-bootstrap modal re apiman#1107 API Entity UI-bootstrap modal re apiman#1107 API Policies UI-bootstrap modal Admin Plugins UI-bootstrap modal Admin gateways, edit role, edit gateway, edit plugin page updates for UI-bootstrap modals Admin manage members UI-bootstrap modals Plan policies UI-bootstrap modals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
ClientAppDeleteModalCtrlto new module.Screenshots:
Confirm Upgrade Plugin:
JIRA: https://issues.jboss.org/browse/APIMAN-1169
cc @EricWittmann - If possible, please test prior to merging. I manually tested as I went along, but there are a lot of pages with a lot of changes. Apologies for some of the reformatting (yes, again); I remembered afterward and stopped doing it lol.
Please note that there is a ton of HTML that is repeated -- namely the modal templates -- but I couldn't get the path working properly to reference a single HTML file, so I had to add the template to each page that needed it. This can be improved by either resolving the path issue or possibly by using
ng-include(which may or may not cause issues, but worth a try).