feat(gateway-vertx) new host property in verticles config #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good. @msavy may already have left for vacation - I'll give this a little bit of time (for him to see it and comment) before merging it. :) |
|
Hey @msavy I haven't merged this yet because one of the travis builds fails. I don't see an immediate cause for the failure so you might need to have a look. |
|
Yes, I’ve been investigating it in my spare time during holiday. I think it might be a problem with the latest JDK 8 release causing memory usage issues (I recall it being mentioned by one of the team).
I’ll review as soon as I have the blockers out of the way and I have a moment.
… On 12 Oct 2017, at 20:29, Eric Wittmann ***@***.***> wrote:
Hey @msavy <https://github.com/msavy> I haven't merged this yet because one of the travis builds fails. I don't see an immediate cause for the failure so you might need to have a look.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#627 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAZ2WfepBvNlzZWI9qv4Ym_W4WTmMHL0ks5srlpygaJpZM4PvE12>.
|
|
OK cool. No worries obviously I just wasn't sure this was on your radar. :) |
|
Not at all, thanks for the comment! |
|
Not forgotten about this. Will review adding this shortly! :-) |
|
@jriquelme: thanks for contributing and helping to make Apiman better and better! Your efforts are much appreciated 🎉. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check https://issues.jboss.org/browse/APIMAN-1292