Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(multiple-auth): add support for multiple auth #51

Merged
merged 7 commits into from
Dec 4, 2023

Conversation

sufyankhanrao
Copy link
Collaborator

What

This PR updates the authentication interface and incorporates the instance methods used for the validation of auth schemes. other than validation results, it also stores the error message for each auth scheme instance.

Why

To support the multiple auth schemes in the core library

closes #50

Type of change

Select multiple if applicable.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause a breaking change)
  • Tests (adds or updates tests)
  • Documentation (adds or updates documentation)
  • Refactor (style improvements, performance improvements, code refactoring)
  • Revert (reverts a commit)
  • CI/Build (adds or updates a script, change in external dependencies)

Dependency Change

If a new dependency is being added, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Policy-of-adding-new-dependencies-in-the-core-libraries

Breaking change

If the PR is introducing a breaking change, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Guidelines-for-maintaining-core-libraries

Testing

List the steps that were taken to test the changes

Checklist

  • My code follows the coding conventions
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added new unit tests

This commit updates the authentication interface and incorporates the instance methods used for the validation of auth schemes. other than validation results, it also stores the error message for each auth scheme instance.

closes #50
@sufyankhanrao sufyankhanrao added the enhancement New feature or request label Oct 3, 2023
@sufyankhanrao sufyankhanrao self-assigned this Oct 3, 2023
asadali214
asadali214 previously approved these changes Oct 4, 2023
asadali214
asadali214 previously approved these changes Oct 5, 2023
@sufyankhanrao sufyankhanrao merged commit f16afbe into main Dec 4, 2023
4 checks passed
@sufyankhanrao sufyankhanrao deleted the 50-add-support-for-multiple-auth branch December 4, 2023 10:20
sufyankhanrao added a commit that referenced this pull request Dec 8, 2023
sufyankhanrao added a commit that referenced this pull request Dec 8, 2023
sufyankhanrao added a commit that referenced this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for multiple auth
2 participants