-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(logging): add support for structured logging #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rraySerializationFormat
hamzamahmood
changed the title
feat(add-structured-logging): add support for structured logging
feat(logging): add support for structured logging
Apr 18, 2024
…eadOnlyResponseLogging to ReadonlyResponseLogOptions
sufyankhanrao
requested changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly update ReadMe for new added interfaces.
sufyankhanrao
previously approved these changes
Apr 18, 2024
sufyankhanrao
previously approved these changes
Apr 18, 2024
src/main/java/io/apimatic/coreinterfaces/logger/configuration/ReadonlyLogOptions.java
Outdated
Show resolved
Hide resolved
sufyankhanrao
previously approved these changes
Apr 19, 2024
sufyankhanrao
previously approved these changes
Apr 19, 2024
Quality Gate passedIssues Measures |
sufyankhanrao
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR updates the current implementation of the logging and logging configuration and some code cleanup changes.
Why
The following changes are made to make the logging in Java robust and add the support for multilevel log option configuration to improve the user experience.
Type of change
Select multiple if applicable.
Dependency Change
org.slf4j dependency has been added.
Breaking change
Changes in ReadonlyLogging will be a breaking change for the user
Testing
We have added unit tests for logging request
Checklist