Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency on enum34 #59

Closed
lsnliu opened this issue May 10, 2024 · 4 comments · Fixed by #60 or #61
Closed

Dependency on enum34 #59

lsnliu opened this issue May 10, 2024 · 4 comments · Fixed by #60 or #61
Assignees
@sufyankhanrao
Labels
bug Something isn't working reported-by-consumer Points to the bugs reported by consumers

Comments

@lsnliu
Copy link

lsnliu commented May 10, 2024

Describe the bug
The package has a dependency on enum34 which is no longer required after python 3.6 based on my google research. Could be wrong entirely.

image

This causes the standard class attribute error AttributeError: module 'enum' has no attribute 'IntFlag' in certain environments. In my specific scenario, it's azure app service.

To Reproduce
Steps to reproduce the behavior:

  1. Reproduction of this bug would require you to have an azure web app for python.
  2. deploy any code with your package in the requirements.txt and the server will fail to start and show that error

Expected behavior
enum import error should not occur

Screenshots
If applicable, add screenshots to help explain your problem.

Environment
Linux python 3.10.11

Library version
0.2.9

Additional context
I believe that it doesn't matter if it causes errors in only specific scenarios. Given this is no longer required post python3.6, it should not be utilized.
thanks
@lsnliu lsnliu added bug Something isn't working reported-by-consumer Points to the bugs reported by consumers labels May 10, 2024
@sufyankhanrao
Copy link
Collaborator

Hey @lsnliu,
Thank you for reporting this and we are investigating this on our side.

sufyankhanrao added a commit that referenced this issue May 16, 2024
@sufyankhanrao
build(enum34): remove enum34 dependency
3d4a9fc 
This commit removes the enum34 dependency from the core library as the enum34 dependency is not needed for Python versions 3.7 onwards and we support python version 3.7 onwards.

closes #59
@sufyankhanrao sufyankhanrao mentioned this issue May 17, 2024
Merged
12 tasks
@sufyankhanrao sufyankhanrao self-assigned this May 17, 2024
sufyankhanrao added a commit that referenced this issue May 21, 2024
@sufyankhanrao
build(enum34): remove enum34 dependency (#60)
4536465 
This commit removes the enum34 dependency from the core library as the enum34 dependency is not needed since Python version 3.4 and we support Python version >= 3.7.

closes #59
@lsnliu
Copy link
Author

lsnliu commented May 21, 2024

Thanks for this.

I just tried pip uninstall and pip install again and your package's dependency still includes enum34. When will that be updated?

image

sufyankhanrao added a commit that referenced this issue May 21, 2024
@sufyankhanrao
build(enum34): remove enum34 dependency from setup
5997538 
This commit removes the enum34 dependency from the core library as the enum34 dependency is not needed since Python version 3.4 and we support Python version >= 3.7.

closes #59
@sufyankhanrao sufyankhanrao mentioned this issue May 21, 2024
Merged
12 tasks
sufyankhanrao added a commit that referenced this issue May 21, 2024
@sufyankhanrao
build(enum34): remove enum34 dependency from setup (#61)
bab9d8d 
This commit removes the enum34 dependency from the core library as the enum34 dependency is not needed since Python version 3.4 and we support Python version >= 3.7.

closes #59
@sufyankhanrao
Copy link
Collaborator

Thanks for this.

I just tried pip uninstall and pip install again and your package's dependency still includes enum34. When will that be updated?

image

Hey @lsnliu,
This has been addressed in the latest version i.e. 0.2.12. Can you please retry now?

@lsnliu
Copy link
Author

lsnliu commented May 21, 2024

Works, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sufyankhanrao sufyankhanrao

Labels
bug Something isn't working reported-by-consumer Points to the bugs reported by consumers
Projects
None yet
Milestone
No milestone
2 participants
@lsnliu @sufyankhanrao