Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(enum34): remove enum34 dependency #60

Merged
merged 2 commits into from
May 21, 2024

Conversation

sufyankhanrao
Copy link
Collaborator

What

This PR removes the enum34 dependency from the core library as the enum34 dependency is not needed for Python versions 3.7 onwards and we support python version 3.7 onwards.

Why

The enum module was introduced in Python 3.4, providing a built-in way to define enumerations. The enum34 library is a backport of the enum module for Python versions before 3.4. As we support python versions >= 3.7 therefore it is not required anymore.

closes #59

Type of change

Select multiple if applicable.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause a breaking change)
  • Tests (adds or updates tests)
  • Documentation (adds or updates documentation)
  • Refactor (style improvements, performance improvements, code refactoring)
  • Revert (reverts a commit)
  • CI/Build (adds or updates a script, change in external dependencies)

Dependency Change

If a new dependency is being added, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Policy-of-adding-new-dependencies-in-the-core-libraries

Breaking change

If the PR is introducing a breaking change, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Guidelines-for-maintaining-core-libraries

Testing

List the steps that were taken to test the changes

Checklist

  • My code follows the coding conventions
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added new unit tests

This commit removes the enum34 dependency from the core library as the enum34 dependency is not needed for Python versions 3.7 onwards and we support python version 3.7 onwards.

closes #59
@sufyankhanrao sufyankhanrao self-assigned this May 17, 2024
Copy link

sonarcloud bot commented May 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sufyankhanrao sufyankhanrao requested review from MaryamAdnan3 and removed request for MaryamAdnan3 May 17, 2024 08:21
@sufyankhanrao sufyankhanrao merged commit 4536465 into main May 21, 2024
7 checks passed
@sufyankhanrao sufyankhanrao deleted the 59-remove-enum34-dependency branch May 21, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency on enum34
2 participants