Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue of body_param in RequestBuilder class #8

Closed
sufyankhanrao opened this issue Oct 7, 2022 · 0 comments · Fixed by #9
Closed

Fix issue of body_param in RequestBuilder class #8

sufyankhanrao opened this issue Oct 7, 2022 · 0 comments · Fixed by #9
Assignees
@sufyankhanrao
Labels
bug Something isn't working

Comments

@sufyankhanrao
Copy link
Collaborator

The task is to fix issues for body_param property when serializing the request body. Flow is breaking when body_param contains simple boolean value as False and the check should be refactored to _body_param is not None.
@sufyankhanrao sufyankhanrao added the bug Something isn't working label Oct 7, 2022
@sufyankhanrao sufyankhanrao self-assigned this Oct 7, 2022
sufyankhanrao added a commit that referenced this issue Oct 7, 2022
@sufyankhanrao
fix(8-body-param-issue): update body param to handle simple False value
62e7740 
This commit bears a fix for the body param while serializing the request. There might be cases where request body parameter contain simple boolean value like False/True then the behavior of body serialization will fail therefore this change adds the not None check for the request body parameter.

closes #8
@sufyankhanrao sufyankhanrao mentioned this issue Oct 7, 2022
Merged
sufyankhanrao added a commit that referenced this issue Oct 10, 2022
@sufyankhanrao
fix(8-body-param-issue): update body param to handle simple False val…
5f84cde 
…ue (#9)

This commit bears a fix for the body param while serializing the request. There might be cases where the request body parameter contains a simple boolean value like False/True then the behavior of body serialization will fail therefore this change adds the "not none" check for the request body parameter.

closes #8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sufyankhanrao sufyankhanrao

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(8-body-param-issue): update body param to handle simple False value apimatic/core-lib-python
1 participant
@sufyankhanrao