Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove upload system modularity #332

Merged
merged 2 commits into from
Nov 27, 2017
Merged

Remove upload system modularity #332

merged 2 commits into from
Nov 27, 2017

Conversation

tulir
Copy link
Collaborator

@tulir tulir commented Aug 1, 2017

Fixes #325

This pull request removes the semi-modular upload system in favor of a more focused Space-only upload system.

@tulir tulir added this to the 1.3.0 milestone Aug 1, 2017
@tulir tulir mentioned this pull request Sep 7, 2017
Open
@ghost ghost assigned tulir Oct 31, 2017
@tulir tulir requested a review from JeHugawa October 31, 2017 11:22
@tulir
Copy link
Collaborator Author

tulir commented Oct 31, 2017

@JeHugawa The basic modularity removal is done, but no additional features have been added. We should probably just merge this and work on the features separately. There's a TODO list at #345

@JeHugawa JeHugawa merged commit 649ed9a into master Nov 27, 2017
@ghost ghost removed the ready for review label Nov 27, 2017
@JeHugawa JeHugawa deleted the feature/remove-sky branch June 15, 2018 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeHugawa JeHugawa JeHugawa approved these changes

Assignees

@tulir tulir

Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tulir @JeHugawa