Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user-confirmation on success when submitting Add API Backend form #426

Closed
2 of 3 tasks
brylie opened this issue Sep 2, 2015 · 4 comments
Closed
2 of 3 tasks

Add user-confirmation on success when submitting Add API Backend form #426

brylie opened this issue Sep 2, 2015 · 4 comments
Assignees
@mauriciovieira
Labels
enhancement
Milestone
Sprint 13

Comments

@brylie
Copy link
Contributor

brylie commented Sep 2, 2015

When a user successfully submits the Add API Backend form, display a confirmation message.

Definition of done

  • Add autoform onSuccess hook to Add API backend form.
  • Using onSuccess hook display success message on UI.
  • Redirect to API view.
@bajiat bajiat added ready and removed planning labels Sep 14, 2015
@55 55 added in progress and removed ready labels Sep 15, 2015
@brylie brylie modified the milestone: Sprint 12 Sep 17, 2015
@55
Copy link
Contributor

55 commented Sep 25, 2015

onSuccess message added.

@55 55 added ready and removed in progress labels Sep 28, 2015
@bajiat bajiat modified the milestones: Sprint 13, Sprint 12 Sep 30, 2015
@brylie brylie assigned mauriciovieira and unassigned 55 Oct 5, 2015
@brylie
Copy link
Contributor Author

brylie commented Oct 5, 2015

I am assigning Mauricio (@mauriciovieira) to this task.

@mauriciovieira
Copy link
Contributor

"Redirect to API view." is done.

mauriciovieira added a commit that referenced this issue Oct 5, 2015
@mauriciovieira
Redirect to API Backend page - closes #426
4acd59e 
* As it redirects, the success message is never shown, so the call was removed.
mauriciovieira added a commit that referenced this issue Oct 5, 2015
@mauriciovieira
Redirect to API Backend page - closes #426
b39e50d 
As it redirects, the success message is never shown. That's why all sAlert references were removed.
@brylie
Copy link
Contributor Author

brylie commented Oct 6, 2015

We determined the UI message was not necessary, so removed it from the onSuccess callback.

@brylie brylie closed this as completed Oct 6, 2015
@brylie brylie removed the in progress label Oct 6, 2015
brylie added a commit that referenced this issue Oct 7, 2015
@brylie
Merge pull request #507 from apinf/feature/confirmation-success-apiba…
c8ab91d 
…ckend

Redirect to API Backend page - closes #426
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mauriciovieira mauriciovieira

Labels
enhancement
Projects
None yet
Milestone
Sprint 13
Development

No branches or pull requests
4 participants
@brylie @mauriciovieira @55 @bajiat