Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Override Response Headers field to Add API Backend form #504

Closed
2 of 7 tasks
brylie opened this issue Oct 5, 2015 · 3 comments · Fixed by #566
Closed
2 of 7 tasks

Add Override Response Headers field to Add API Backend form #504

brylie opened this issue Oct 5, 2015 · 3 comments · Fixed by #566
Assignees
Milestone

Comments

@brylie
Copy link
Contributor

brylie commented Oct 5, 2015

The "Override Response Headers" field is not currently available on the Add API Backend form. This is inconsistent with the API Umbrella system.

Help text should read:

Define header values that will be set in the response regardless of whether the header is already set in the response.

For example, to force CORS headers on all responses:

Access-Control-Allow-Origin: *

Task

Verify existing field in API Umbrella

  • Verify "Default Response Headers" field design on API Umbrella API Backend form
  • Make note of field design, location on form, etc

Implement field in Apinf

  • Update ApiBackends schema to include "Override Response Headers" field
  • Ensure schema definition matches API Umbrella field name and validation settings
  • Add field to Add API Backend form

Test new field

  • Manually test that form submits both with and without field input
    • Ensure that submitted data is present in API Umbrella, i.e. that it validates
@bajiat bajiat added the planning label Oct 8, 2015
@bajiat
Copy link
Contributor

bajiat commented Oct 13, 2015

@mauriciovieira I checked your task estimations for sprint 14 and it is about 25 hours. You estimated your availability as 49 hours. Some of that time will go to reviewing PR's, but would it also be possible for you to take tasks #504 and #503?

@mauriciovieira mauriciovieira self-assigned this Oct 14, 2015
@bajiat bajiat added ready and removed planning labels Oct 15, 2015
@mauriciovieira mauriciovieira removed their assignment Oct 22, 2015
@bajiat bajiat added planning and removed ready labels Oct 22, 2015
@brylie brylie added this to the Sprint 15 milestone Oct 26, 2015
@brylie
Copy link
Contributor Author

brylie commented Oct 26, 2015

Co-pilot: @elnzv

@jykae
Copy link
Contributor

jykae commented Oct 30, 2015

Will this actually reset whatever there is in Response Headers? Could CORS header only be added to the set? Issue created with question NREL/api-umbrella#186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants