Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor elastic-rest package for meteor #665

Closed
3 of 4 tasks
frenchbread opened this issue Nov 30, 2015 · 2 comments
Closed
3 of 4 tasks

Refactor elastic-rest package for meteor #665

frenchbread opened this issue Nov 30, 2015 · 2 comments
Assignees
Milestone

Comments

@frenchbread
Copy link
Contributor

Research

  • Go through ES & read the docs.

Refactor

  • Allow providing configuration object as an additional parameter for ElasticRest() class e.g.:
  • Add error handling.
var config = {
    "host": "es_host"
};

var options = {
    "index": "index_value",
    "type": "type_value",
    "limit": 100,
    "query": "query_object",
    "fields": "fields_array"
};

new ElasticRest(config, options);

Apinf

  • Refactor getChartsData method to support updated API in elastic-rest package.
@frenchbread frenchbread added this to the Sprint 17 milestone Nov 30, 2015
@frenchbread frenchbread self-assigned this Nov 30, 2015
@frenchbread
Copy link
Contributor Author

Updated meteor-elastic-rest package to v1.0.

Next, I'm going to create a separate branch to apply changes added to ElasticRest class API.

@frenchbread
Copy link
Contributor Author

PR #678. Please review.

@55 55 closed this as completed in 71f166c Dec 4, 2015
@55 55 removed the in progress label Dec 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants