Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/elastic rest package update - closes #665 #678

Merged
merged 2 commits into from
Dec 4, 2015

Conversation

frenchbread
Copy link
Contributor

@apinf/developers please review.
#665 related issue.

Also have a look at the updated meteor package.

Testing:

When testing, make sure that the package is updated & then open dashboard page. Analytics data should be there.

@55 55 self-assigned this Dec 3, 2015
query,
data.fields
);
var config = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to define it in server/startup.js file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elnzv Why would you need that?

If you want you can change the host value to be fetched directly from settings collection rather than from settings.json file.

55 pushed a commit that referenced this pull request Dec 4, 2015
Feature/elastic rest package update - closes #665
@55 55 merged commit 71f166c into develop Dec 4, 2015
@55 55 removed the in progress label Dec 4, 2015
@55 55 deleted the feature/elastic-rest-package-update branch December 4, 2015 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants