Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure settings, including example.settings.json, are refactured to match settings page PR structure #709

Closed
brylie opened this issue Dec 14, 2015 · 4 comments
Closed

Make sure settings, including example.settings.json, are refactured to match settings page PR structure #709

brylie opened this issue Dec 14, 2015 · 4 comments
Assignees
@55
Labels
Cleanup low hanging fruit
Milestone
Sprint 21

Comments

@brylie
Copy link
Contributor

brylie commented Dec 14, 2015

The Settings Page feature made changes to the way settings are handled. As a follow up to that task, we need to check that all settings are updated in throughout our app, including the example.settings.json, to match the new structure.

Specifically:

  • apiUmbrella
  • elasticSearch
  • mail
  • contactForm
  • githubConfiguration
@brylie
Copy link
Contributor Author

brylie commented Dec 16, 2015

This issue is related to the review process for @elnzv issue #327

@brylie brylie mentioned this issue Jan 4, 2016
Closed
1 task
@bajiat bajiat added this to the Sprint 20 milestone Jan 4, 2016
@brylie brylie added ready and removed planning labels Jan 4, 2016
@brylie brylie removed their assignment Jan 18, 2016
@bajiat
Copy link
Contributor

bajiat commented Jan 25, 2016

@apinf/developers Who wants to volunteer for this task?

@55 55 self-assigned this Jan 26, 2016
@55 55 modified the milestones: Sprint 21, Sprint 20 Jan 26, 2016
@55
Copy link
Contributor

55 commented Jan 29, 2016

Checked. That have already been done.
See this commit:
apinf/api-umbrella-dashboard@5824acb

@apinf/developers, please confirm and close this issue.

@brylie
Copy link
Contributor Author

brylie commented Jan 29, 2016

OK, go ahead and close.

@55 55 closed this as completed Jan 29, 2016
@55 55 removed the in progress label Jan 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@55 55

Labels
Cleanup low hanging fruit
Projects
None yet
Milestone
Sprint 21
Development

No branches or pull requests
3 participants
@brylie @55 @bajiat