Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the apinf.host setting with a call to Meteor.absoluteUrl() #743

Closed
1 task done
brylie opened this issue Jan 2, 2016 · 1 comment
Closed
1 task done

Replace the apinf.host setting with a call to Meteor.absoluteUrl() #743

brylie opened this issue Jan 2, 2016 · 1 comment
Assignees
@sebbel
Labels
bug

Comments

@brylie
Copy link
Contributor

brylie commented Jan 2, 2016

Related to #709.
We currently have an unnecessary setting:

apinf: {
  host: "--"
}

Remove this setting from the settings form, readme, and from within our code.

Definition of done

  • Any usage of apinf.host setting is replaced with Meteor.absoluteUrl().
@brylie brylie added the bug label Jan 2, 2016
@bajiat bajiat added the planning label Jan 4, 2016
@sebbel
Copy link
Contributor

sebbel commented Jan 4, 2016

I replaced the unnecessary setting in this branch.
https://github.com/apinf/api-umbrella-dashboard/tree/bugfix/743-apinf-host

@brylie brylie added this to the Sprint 20 milestone Jan 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebbel sebbel

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@brylie @sebbel @frenchbread @bajiat