-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix/api umbrella methods sync #1062
Conversation
@apinf/developers Please review & test |
@frenchbread Overall code and solution looked good. Settings file usage won't be anymore supported I suppose? |
Yes. But basically, as I recall correctly there were some feature that transfers settings data from setting file to collection. |
@frenchbread yes. We should probably still allow settings to be provided by settings.json, so in startup we could write the |
Not syncing, should I wait 5 mins, or still bug? |
@@ -0,0 +1,14 @@ | |||
export function apiUmbrellaSettigsValid (settings) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add letter 'n' for everywhere this function gets called and function name.
apiUmbrellaSettigsValid => apiUmbrellaSettingsValid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch.
Generally: |
Decided together to leave settings file case outside of this. |
Added some more refactoring & checks |
Tested again after meteor reset, sync runs now without errors. |
Added one more close to the description. Merging and closing. If one minute syncing interval causes issues for example in production when there might be more latency let's make it longer. Great co-working guys @frenchbread @brylie |
Fixes