-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/api rating bookmark data model #1131
Conversation
apiBackend.setAverageRating(); | ||
}); | ||
}, | ||
setApiBackendAverageRating (apiBackendId) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brylie method name here could be something like set ApiBackendBookmarkCount
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which method? The setApiBackendAverageRating
is related to the averageRating
field. Hence, this method is in the ratings.js
file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brylie Ok, I confused this because console.log says about bookmarks. Could you also cleanup/fix console.logs?
@brylie Overall nice work, other thing to fix before I merge this, EDIT: We need to decide if we continue to use percolate:migrations, package needs maintainer https://github.com/percolatestudio/meteor-migrations#call-for-maintainers |
…o feature/api-rating-bookmark-data-model
Ok, merging in, so I can integrate this to my table view. Thanks @brylie |
Closes #1130
Proposed changes
averageRating
andbookmarkCount
fields to ApiBackendssetAverageRating
collection helper for ApiBackendsgetAverageRating
andgetBookmarkCount
helpers for ApiBackendssetAllApiBackendAverageRatings
method