-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/documentation editor host undefined #1185
Bugfix/documentation editor host undefined #1185
Conversation
For reviewer: |
Further notice: |
@apinf/developers ready for review |
Reviewing this PR. @jykae While testing, I noticed that when incorrect url is provided the modal window instantly hides and the error text is not visible. Should we continue showing modal if there were a validation error? |
@frenchbread Incorrect URL for editor in settings? I think it is admin responsibility to set up Apinf correctly. Or what incorrect URL you mean, something in modal? |
Works good. Merging. As discussed, potentially we can provide a select box with existing and know editors rather than making a user fill the url by himself. Also currently, any url, not related to editor can be stored. |
Closes #1057
Proposed changes