Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/documentation editor host undefined #1185

Merged
merged 5 commits into from
Jun 22, 2016

Conversation

jykae
Copy link
Contributor

@jykae jykae commented Jun 20, 2016

Closes #1057

Proposed changes

  • fix subscriptions for documentation editor
  • show "Create documentation" section with link on API "Documentation" tab when Editor is enabled and host settings is set

@jykae jykae added this to the Sprint 25 milestone Jun 20, 2016
@jykae
Copy link
Contributor Author

jykae commented Jun 20, 2016

For reviewer:
Documentation editor section would be available on "Documentation" tab of API in "Manage" modal when Editor settings are ok. For host try http://editor.apinf.io OR http://editor.swagger.io

@jykae
Copy link
Contributor Author

jykae commented Jun 20, 2016

Further notice:
I will put "Enabled" style the same way as it is with "Mail", so that these settings look consistent. Marking WIP..

@jykae jykae added the WIP label Jun 20, 2016
@jykae jykae removed the WIP label Jun 20, 2016
@jykae
Copy link
Contributor Author

jykae commented Jun 20, 2016

@apinf/developers ready for review

@frenchbread
Copy link
Contributor

frenchbread commented Jun 21, 2016

Reviewing this PR.

@jykae While testing, I noticed that when incorrect url is provided the modal window instantly hides and the error text is not visible. Should we continue showing modal if there were a validation error?

@jykae
Copy link
Contributor Author

jykae commented Jun 21, 2016

@frenchbread Incorrect URL for editor in settings? I think it is admin responsibility to set up Apinf correctly. Or what incorrect URL you mean, something in modal?

@frenchbread
Copy link
Contributor

Works good. Merging.

As discussed, potentially we can provide a select box with existing and know editors rather than making a user fill the url by himself. Also currently, any url, not related to editor can be stored.

@frenchbread frenchbread merged commit e244246 into develop Jun 22, 2016
@frenchbread frenchbread deleted the bugfix/documentation-editor-host-undefined branch June 22, 2016 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation Editor 'host' not defined
2 participants