Bugfix/manager ids disappearing service restart #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Last commit is for keeping the functionality the same way as it is with synced API backends that come from Umbrella without owner. |
|
@apinf/developers please review |
|
Good job @jykae! |
| @@ -96,11 +98,6 @@ Template.addApiBackendWizard.helpers({ | |||
| // Add the least connections balance algorithm setting | |||
| apiBackend.balance_algorithm = "least_conn"; | |||
|
|
|||
| // Delete unneeded properties: database insert/update related | |||
| delete apiBackend.insertDoc; | |||
There was a problem hiding this comment.
@frenchbread and @jykae please make sure these apiBackend properties do not get stored in our collection:
insertDocupdateDoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1164
Proposed changes