Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker-compose.yml for production #1223

Merged
merged 1 commit into from
Jul 13, 2016
Merged

Add docker-compose.yml for production #1223

merged 1 commit into from
Jul 13, 2016

Conversation

shaliko
Copy link
Contributor

@shaliko shaliko commented Jun 28, 2016

Closes #1227

  • Add docker-compose.yml for production.
  • Add Docker-compose instructions.

Requires https://github.com/apinf/api-umbrella-dashboard/issues/1216

@jykae
Copy link
Contributor

jykae commented Jun 28, 2016

@shaliko Is require fix also some keyword in Github, this PR is linked to API key issue?. o_O
I think this should be linked and close only the original issue for "Docker production setup".

@shaliko
Copy link
Contributor Author

shaliko commented Jun 28, 2016

@jykae I think 'require' not GitHub keyword, at least I not found information about that ;) I just wanted mark that this feature not really useful until will be fixed issue #1216. User will flow by instructions but will not able create API request.

@jykae
Copy link
Contributor

jykae commented Jun 28, 2016

@shaliko But "fix" is keyword to close given issue: https://help.github.com/articles/closing-issues-via-commit-messages/#keywords-for-closing-issues I update the PR, so that we are not closing API key issue with this PR.

@shaliko
Copy link
Contributor Author

shaliko commented Jun 28, 2016

@jykae OK, got it :)

@shaliko
Copy link
Contributor Author

shaliko commented Jun 28, 2016

@jykae Please do not accept that task right after release #1216 I will need build new image https://github.com/apinf/api-umbrella-dashboard/blob/develop/CONTRIBUTING.md#building-images.

@jykae
Copy link
Contributor

jykae commented Jun 28, 2016

@shaliko Don't worry we are testing this anyway, and #1216 has still some weirdness on saving Branding object.

@jykae jykae self-assigned this Jun 28, 2016
@jykae
Copy link
Contributor

jykae commented Jul 1, 2016

@apinf/developers I won't be able to review this today before summer vacation. Could someone else review this?

@brylie brylie assigned brylie and unassigned jykae Jul 4, 2016
@brylie
Copy link
Contributor

brylie commented Jul 6, 2016

@shaliko #1216 has been merged. Should we merge this PR yet?

@shaliko
Copy link
Contributor Author

shaliko commented Jul 6, 2016

@brylie Thanks for notice, now I need make new Docker images and update pull request. After that we can merge this request, will notice you soon.

@shaliko
Copy link
Contributor Author

shaliko commented Jul 11, 2016

@brylie Updated "apinf/apinf:latest" docker image. We can close that issue.

BTW I will be happy if you will try run docker-compose.yml for production based on instructions.

@bajiat
Copy link
Contributor

bajiat commented Jul 11, 2016

@NNN Will you try to run docker-compose.yml with instructions?

@55
Copy link
Contributor

55 commented Jul 12, 2016

@bajiat, copy.

@55 55 assigned 55 and unassigned brylie Jul 12, 2016
@55
Copy link
Contributor

55 commented Jul 13, 2016

@shaliko, please finish with docker compose instructions based on our yesterday discussion.

@shaliko
Copy link
Contributor Author

shaliko commented Jul 13, 2016

@NNN Updated.

@55 55 merged commit b9a7e4b into develop Jul 13, 2016
@55 55 removed the in progress label Jul 13, 2016
@55 55 deleted the docker-for-production branch July 13, 2016 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants