-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker-compose.yml for production #1223
Conversation
@shaliko Is require fix also some keyword in Github, this PR is linked to API key issue?. o_O |
@shaliko But "fix" is keyword to close given issue: https://help.github.com/articles/closing-issues-via-commit-messages/#keywords-for-closing-issues I update the PR, so that we are not closing API key issue with this PR. |
@jykae OK, got it :) |
@jykae Please do not accept that task right after release #1216 I will need build new image https://github.com/apinf/api-umbrella-dashboard/blob/develop/CONTRIBUTING.md#building-images. |
@apinf/developers I won't be able to review this today before summer vacation. Could someone else review this? |
@brylie Thanks for notice, now I need make new Docker images and update pull request. After that we can merge this request, will notice you soon. |
@brylie Updated "apinf/apinf:latest" docker image. We can close that issue. BTW I will be happy if you will try run docker-compose.yml for production based on instructions. |
@NNN Will you try to run docker-compose.yml with instructions? |
@bajiat, copy. |
0904d24
to
c819e7e
Compare
@shaliko, please finish with docker compose instructions based on our yesterday discussion. |
c819e7e
to
7f9d5f9
Compare
7f9d5f9
to
dfeab78
Compare
@NNN Updated. |
Closes #1227
Requires https://github.com/apinf/api-umbrella-dashboard/issues/1216